Skip to content

Enable comparator on nRF54L20 #21893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Enable comparator on nRF54L20 #21893

wants to merge 1 commit into from

Conversation

@nordic-segl
Copy link
Contributor

@nordic-segl nordic-segl commented Apr 17, 2025

No description provided.

@nordic-segl nordic-segl requested review from a team as code owners April 17, 2025 05:42
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Apr 17, 2025
@nordic-segl nordic-segl mentioned this pull request Apr 17, 2025
Closed
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 17, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@91f0955 nrfconnect/sdk-zephyr#2781 nrfconnect/sdk-zephyr#2781/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 17, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: 9c9292c02017a8e2e4602006e820bf20e384d06d
zephyr: PR head: 954eaf26843031dd9a9d51afd33da60dd7d7130a

more details

sdk-nrf:

PR head: 9c9292c02017a8e2e4602006e820bf20e384d06d
merge base: a64e6ee0e8cd02647754904c7e02ceaeae8f627e
target head (main): a64e6ee0e8cd02647754904c7e02ceaeae8f627e
Diff

zephyr:

PR head: 954eaf26843031dd9a9d51afd33da60dd7d7130a
merge base: 7607c65855669ed61b8c74e4bf38841396f2c30d
target head (main): 87432d9d76e7e52a2831b24b4854629047875997
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (4) 
west.yml
zephyr
│  ├── drivers
│  │  ├── comparator
│  │  │  ├── comparator_nrf_comp.c
│  │  │  │ comparator_nrf_lpcomp.c
│  ├── tests
│  │  ├── boards
│  │  │  ├── nrf
│  │  │  │  ├── comp
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ test.c

Outputs:

Toolchain

Version: 7cbc0036f4
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:7cbc0036f4_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 7
    • sdk-zephyr test count: 508
  • ✅ Integration tests
    • ✅ test-low-level
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@nordic-segl
Copy link
Contributor Author

nordic-segl commented Apr 17, 2025 •
edited
Loading

west build -b [email protected]/nrf54lm20a/cpuapp --pristine --test-item nrf.extended.drivers.comparator.nrf_comp .

*** Booting nRF Connect SDK v2.9.99-eabc8560cc49 ***
*** Using Zephyr OS v4.0.99-775da1e341a0 ***
Running TESTSUITE comparator_runtime_configure
===================================================================
Test executed on [email protected]/nrf54lm20a/cpuapp
===================================================================
START - test_comp_config_diff_both
 PASS - test_comp_config_diff_both in 0.031 seconds
===================================================================
START - test_comp_config_diff_falling
 PASS - test_comp_config_diff_falling in 0.021 seconds
===================================================================
START - test_comp_config_diff_none
 PASS - test_comp_config_diff_none in 0.021 seconds
===================================================================
START - test_comp_config_diff_rising
 PASS - test_comp_config_diff_rising in 0.021 seconds
===================================================================
START - test_comp_config_se_aref
 PASS - test_comp_config_se_aref in 0.031 seconds
===================================================================
START - test_comp_config_se_vdd
 PASS - test_comp_config_se_vdd in 0.031 seconds
===================================================================
TESTSUITE comparator_runtime_configure succeeded

------ TESTSUITE SUMMARY START ------

SUITE PASS - 100.00% [comparator_runtime_configure]: pass = 6, fail = 0, skip = 0, total = 6 duration = 0.156 seconds
 - PASS - [comparator_runtime_configure.test_comp_config_diff_both] duration = 0.031 seconds
 - PASS - [comparator_runtime_configure.test_comp_config_diff_falling] duration = 0.021 seconds
 - PASS - [comparator_runtime_configure.test_comp_config_diff_none] duration = 0.021 seconds
 - PASS - [comparator_runtime_configure.test_comp_config_diff_rising] duration = 0.021 seconds
 - PASS - [comparator_runtime_configure.test_comp_config_se_aref] duration = 0.031 seconds
 - PASS - [comparator_runtime_configure.test_comp_config_se_vdd] duration = 0.031 seconds

------ TESTSUITE SUMMARY END ------

===================================================================
PROJECT EXECUTION SUCCESSFUL

west build -b [email protected]/nrf54lm20a/cpuapp --pristine --test-item nrf.extended.drivers.comparator.gpio_loopback.nrf_comp .
and
west build -b [email protected]/nrf54lm20a/cpuapp --pristine --test-item nrf.extended.drivers.comparator.gpio_loopback.nrf_lpcomp .

*** Booting nRF Connect SDK v2.9.99-eabc8560cc49 ***
*** Using Zephyr OS v4.0.99-775da1e341a0 ***
Running TESTSUITE comparator_gpio_loopback
===================================================================
START - test_get_output
 PASS - test_get_output in 0.005 seconds
===================================================================
START - test_no_trigger_no_pending
 PASS - test_no_trigger_no_pending in 0.003 seconds
===================================================================
START - test_trigger_both_edges_pending
 PASS - test_trigger_both_edges_pending in 0.004 seconds
===================================================================
START - test_trigger_callback
 PASS - test_trigger_callback in 0.004 seconds
===================================================================
START - test_trigger_falling_edge_pending
 PASS - test_trigger_falling_edge_pending in 0.004 seconds
===================================================================
START - test_trigger_rising_edge_pending
 PASS - test_trigger_rising_edge_pending in 0.004 seconds
===================================================================
TESTSUITE comparator_gpio_loopback succeeded

------ TESTSUITE SUMMARY START ------

SUITE PASS - 100.00% [comparator_gpio_loopback]: pass = 6, fail = 0, skip = 0, total = 6 duration = 0.024 seconds
 - PASS - [comparator_gpio_loopback.test_get_output] duration = 0.005 seconds
 - PASS - [comparator_gpio_loopback.test_no_trigger_no_pending] duration = 0.003 seconds
 - PASS - [comparator_gpio_loopback.test_trigger_both_edges_pending] duration = 0.004 seconds
 - PASS - [comparator_gpio_loopback.test_trigger_callback] duration = 0.004 seconds
 - PASS - [comparator_gpio_loopback.test_trigger_falling_edge_pending] duration = 0.004 seconds
 - PASS - [comparator_gpio_loopback.test_trigger_rising_edge_pending] duration = 0.004 seconds

------ TESTSUITE SUMMARY END ------

===================================================================
PROJECT EXECUTION SUCCESSFUL

@github-actions
Copy link

github-actions bot commented Apr 17, 2025

You can find the documentation preview for this PR here.

@nordic-segl nordic-segl force-pushed the NRFX-7312_Enable-comparator-on-54L20 branch from eabc856 to e397702 Compare April 17, 2025 06:26
@nordic-segl
Copy link
Contributor Author

nordic-segl commented Apr 17, 2025 

08:41:18  INFO    - 1/3 [email protected]/nrf54lm20a/cpuapp nrf.extended.drivers.comparator.gpio_loopback.nrf_comp PASSED (device: 1051500724, 4.482s <zephyr>)
08:41:18  INFO    - 2/3 [email protected]/nrf54lm20a/cpuapp nrf.extended.drivers.comparator.nrf_comp           PASSED (device: 1051500724, 3.397s <zephyr>)
08:41:20  INFO    - 3/3 [email protected]/nrf54lm20a/cpuapp nrf.extended.drivers.comparator.gpio_loopback.nrf_lpcomp PASSED (device: 1051500724, 2.958s <zephyr>)

nordicjm
nordicjm reviewed Apr 22, 2025
View reviewed changes
@nordic-segl nordic-segl force-pushed the NRFX-7312_Enable-comparator-on-54L20 branch from e397702 to 52a05b1 Compare April 22, 2025 12:32
@nordic-segl nordic-segl force-pushed the NRFX-7312_Enable-comparator-on-54L20 branch from 52a05b1 to 9c9292c Compare April 23, 2025 06:04
@nordic-segl
Copy link
Contributor Author

nordic-segl commented May 14, 2025

Implemented in a different way.

@nordic-segl nordic-segl deleted the NRFX-7312_Enable-comparator-on-54L20 branch May 14, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nordicjm nordicjm nordicjm left review comments

@nordic-piks nordic-piks nordic-piks approved these changes

Assignees

No one assigned

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM manifest manifest-zephyr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nordic-segl @NordicBuilder @nordicjm @nordic-piks